I look forward to seeing your PR.
I had also identified the EIT_HACK_EXTRAMUXLOOKUP / EIT_HACK_SVCNETLOOKUP anomaly. Looking at GitHub 'blame', this modification goes back to 2018. It looks like a simple copy-paste error.
I M I'm somewhat loath to mess too much with the existing modules and relevant code in eit.c
Your caution is understandable. If you have any questions, there are a number of programmers that may be able to offer some guidance.
I M While I'm reasonably happy with what I've written to deal with the long-standing DVB-T EPG issue we've have outside of Auckland I've never used TVH with DVB-S, nor within the Auckland area, thus am unsure whether these modules are actually needed in such operation, or not.
DVB-S basically uses the same EIT as DVB-T.
You can test with mux dump files from various regions. 'TSDuck' has an archive of such samples. You need to modify the dates when using mux dumps because EPG events in the past will be rejected.
Once I see your PR, I'll test it in Sydney. Our EPG is bog standard EIT so if it works here you have a good chance of it working elsewhere.
I M I'm reminded that this forum has no way to communicate directly with participants,
Correct, the forum currently has no 'direct messaging' feature unfortunately.
I M That said I agree the nomenclature isn't the best,
Depending on how you have implemented your change, there may be a way to do away with the Auckland vs Regional thing and just have a single NZ solution that works for both, possibly even auto-detected. However, not having an Auckland sample to work with makes this impossible to test for now.