VAAPI transcoding code refactoring --> testers needed.

ukn_unknown

Hi team,

I refactored the transcoding (VAAPI) and I need help to evaluate the changes.
tvheadend/tvheadend1781
This branch has the old VAAPI implementation (vaapi_old) and new VAAPI implementation (vaapi). Configure has by default enabled new VAAPI.
New VAAPI implementation is trying to follow the recommended interaction with ffmpeg - as defined in the /docs/examples/.... (files). Decoding, Encoding and transcoding was completely redesigned (as you can see if you try to compare vaapi_old.c and vaapi.c.
If you encounter any issues with new implementation, please rebuild with old implementation and confirm if was working with previous implementation.
I performed tests with Intel platform (Ubuntu), but I don't have HW to test AMD, NVIDIA or Raspberry 4 transcoding.
Please confirm if you see any side effects for other transcoding (like NVENC or MMAL).

Kiril St.

I am testing this branch in linux mint Linux Mint 21.3, with amd rx580, and latest mesa drivers - no problems in h264_vaapi profile. hevc_vaapi is still only audio with no picture.
nvenc no vaapi_old no vaapi yes mmal no omx no

Big thanks for your work to keep code up to date!

ukn_unknown

Kiril St. Thank you for testing. Not having a regression is what we are trying to ensure. Are you sure you have the proper AMF drivers?

Harald Nehring

Is this dependent on a specific ffmpeg version? Static or external ffmpeg build?

ukn_unknown

Harald Nehring I was building using ./Autobuild.sh . This will compile with ffmpeg 6.1.1 static. I used the doc/example from ffmpeg 6.1.1, so going back too much probably is not recommended with external ffmpeg. But irrespective of how I built, try to build with your configuration and let us know if you see any regression (related or unrelated to VAAPI).

ukn_unknown

I partially implemented h264_qsv. QSV only works with Intel platforms. Also you need to have OneVPL installed.
`

prerequisite
sudo apt-get -y autoremove --purge libmfxgen1
LibVPL
sudo apt -y install libvpl-dev
lib OneVPL tools
sudo apt -y install onevpl-tools
libvpl2
sudo apt install libvpl2
libmfx (legacy support)
sudo apt install libmfx-gen1.2
LibMFX
sudo apt install libmfx-dev`

Works:
qsv decode --> qsv encode
qsv decode --> software encode
Not woking:
software decode --> qsv encode
any hardware filters: scale, deinterlace

Also please use built-in muxed (not lib-av).

ukn_unknown

Recommended settings for h264 qsv:

radoo

I have successfully compiled your branch and configured the h264 qsv codec with the settings from the image.
It does not work at all at the moment.
Stream profile parameters:

Error:
2024-11-14 11:11:16.266 libav: AVCodecContext: Invalid pkt_timebase, passing timestamps as-is.
2024-11-14 11:11:16.285 libav: AVHWDeviceContext: libva: Failed to get device id from the driver. Please consider to upgrade the driver to support VA-API 1.15.0
2024-11-14 11:11:16.285 qsv: Decode: Failed to create a context with error code: Unknown error occurred
2024-11-14 11:11:16.307 libav: AVHWDeviceContext: libva: Failed to get device id from the driver. Please consider to upgrade the driver to support VA-API 1.15.0
2024-11-14 11:11:16.307 qsv: Decode: Failed to create a context with error code: Unknown error occurred
2024-11-14 11:11:16.449 qsv: Bitrate = 912 kbps; Buffer size = 10944 kbps; Max bitrate = 1368 kbps

My vainfo:
libva info: VA-API version 1.23.0
libva info: Trying to open /usr/lib/x86_64-linux-gnu/dri/iHD_drv_video.so
libva info: Found init function __vaDriverInit_1_14
libva info: va_openDriver() returns 0
vainfo: VA-API version: 1.23 (libva 2.23.0.pre1)
vainfo: Driver version: Intel iHD driver for Intel(R) Gen Graphics - 22.3.1 ()

ukn_unknown

radoo Please consider to upgrade the driver to support VA-API 1.15.0

based in this error message I assume the driver is not working properly.
options:

virtualization is not working properly
GuC fw is not working ... or some non-free drivers are not installed, follow https://tvheadend.org/d/8884-vaapi-transcoding-code-refactoring-testers-needed/8 and focus on the iGPU11+ . Make sure dmesg will report GuC is loaded by kernel.

ukn_unknown

I added hevc_qsv to the branch ... with limited functionality.
If you use built-in mux stream can be decoded by VLC but cannot be decoded by Kodi or tvhClient.
If you use lib-av mux look ahead has to be disabled ( = 0).
It is far from perfect / ready but give it a try anyway.