Channel mapping bug?

Chris G

My networks are set to “create bouquet”.
This is how all the bouquets are configured:

So why are unnamed services being mapped?

Chris G

Anyone?

Chris G

I can't be the only one to experience this?
428 unnamed channels being mapped despite not having that option enabled:

davep

Two things to try to narrow down the issue:

Enable Debug and Trace logging on the "service mapper" subsystem, then do whatever you do to make the un-named services appear.
Run the following command from a device on your network:
curl "user:pass@http://your.ip.address:9981/api/raw/export?class=service" > services.json
The username and password must be for a tvheadend user which has admin privilege.

Both of these steps will produce a large amount of output. I don't think the forum will take file uploads so you'll have to put the files somewhere else. Remove any sensitive content.

Chris G

Thanks for the reply.
Assuming I have enabled the debugging correctly, I don't seem to be getting any more info than I did before:

2024-10-24 17:19:31.892 bouquet: 28.2E/11426H/{PMT:0}: mapped service from 28.2E

I got that by deleting all channels with "PMT" in the name for this particular network, then doing a force scan on the network created bouquet.

Here is the service from the api:

{ "sid": 10549, "lcn": 0, "lcn_minor": 0, "lcn2": 0, "srcid": 0, "dvb_servicetype": 0, "dvb_ignore_eit": false, "prefcapid": 0, "prefcapid_lock": 0, "force_caid": 0, "pts_shift": 0, "created": 1728426160, "last_seen": 1729786018, "enabled": true, "auto": 0, "priority": 0, "s_type_user": -1, "verified": 0, "pcr": 0, "pmt": 0, "stream": [], "uuid": "4d840711a2be4fb78bac97618e855b34" },

Some networks have way more of these "PMT" channels mapped than others.
I picked this network because it doesn't have many, and it has more tuners.
Hopefully finding the cause will be faster, and I can apply the fix to all networks after.

davep

OK. I see exactly the same "ghost" service on 28.2E/11426H on my Tvheadend system. However it doesn't appear in the "Services" tab of the UI, and because I don't use bouquets I wasn't aware it was there.

I tried downloading a sample of the raw mux and running it through DVB Inspector, and there is no trace of SID 10549!

Looking at the code, the normal process of mapping a service to a channel includes sanity checks (is the service TV or radio?) however the fact that you didn't see any debug or trace messages indicates that the mapping wasn't done that way. Indeed it happens in bouquet_map_channel() in bouquet.c which has no checks.

Can you try adding this line after line 304 in src/bouquet.c:

if (!service_is_tv(t) && !service_is_radio(t)) return;

Chris G

davep

Thanks, that seems to have fixed it.
I had to manually remove existing channels, but they don't seem to be coming back.
Should I have had to manually delete the channels, or should the force scan have removed them for me?
Ideally, TV would automatically keep channels in sync with services as they are created and removed (from EPG scans etc).
I won't know for sure until I live with it for a bit.

While we are at it, is it possible to treat services whose name is the same as the service ID as “unnamed”?

I'll do a pull request if all seems well.

Chris G

Wait a minute. Why did that extra check appear to fix it?
Shouldn't it hit this part and stop?

if (!bq->bq_mapnoname && noname(service_get_channel_name(t))) return;

Because I have the map unnamed channels set to false.

davep

Chris G service_get_channel_name() returns s->s_channel_name(s) if it exists, otherwise it returns s->s_nicename. I haven't fully worked through the code flow, but it seems that s->s_nicename has already been set to the network/mux because s->s_channel_name(s) is null.

Possibly the check should be:
if (!bq->bq_mapnoname && noname(t->s_channel_name(t))) return;

Chris G

I decided to delete all my networks and start over on the unmodified version of TVH.
This time, none of the unnamed "pmt" channels are being mapped.
I have no idea what caused that. If the issue crops up again, I'll post back.