Bug #4964

Missing service info's on network scan

Added by Ricardo Rocha 7 months ago. Updated 7 months ago.

Status:FixedStart date:2018-02-22
Priority:NormalDue date:
Assignee:-% Done:

100%

Category:Service Mapping
Target version:-
Found in version:HTS Tvheadend 4.3-1102~g6d6d79cb7 Affected Versions:

Description

I noticed when doing a network scan that some services are missing in the services tab unless I use "Hide: None". These services are missing info unless I play them.

This picture shows a service missing info before being played in vlc.

samepidbeforeandafterplay.PNG (62.9 KB) Ricardo Rocha, 2018-02-22 09:48

tbl-base-clean-noservices.log (511 KB) Ricardo Rocha, 2018-02-22 09:49

tbl-base-1010.log (636 KB) Ricardo Rocha, 2018-02-22 17:03

new_trace.log (662 KB) Ricardo Rocha, 2018-02-22 17:40

new_trace.log (660 KB) Mark Clarkstone, 2018-02-22 22:04

httpc1.patch Magnifier (1.1 KB) Jaroslav Kysela, 2018-02-22 22:14

Associated revisions

Revision d3b577a9
Added by Jaroslav Kysela 7 months ago

httpc: fix the improper http_client_finish() call for RTP data state, fixes #4964

Revision d58fd123
Added by Jaroslav Kysela 7 months ago

httpc: fix the improper http_client_finish() call for RTP data state, fixes #4964

History

#1 Updated by saen acro 7 months ago

#2 Updated by Jaroslav Kysela 7 months ago

Thanks, upgrade to latest (v4.3-1105-ge4fa6470d), and do a new log (same procedure - remove services, new scan) with "--trace mpegts,satip,tbl-base" .

#3 Updated by Ricardo Rocha 7 months ago

Thanks for the quick try to fix it.... however the problem still exist!

log attached

#4 Updated by Jaroslav Kysela 7 months ago

What's the SAT>IP server? It looks like that the new PIDs are not accepted (see addpids and the status strings from the server):

grep -E "(Status string|SETUP|PLAY params)" //dev/shm/perex-tmpdir/mozilla_perex0/tbl-base-1010.log 
2018-02-22 15:59:37.866 [  TRACE]:satip: 0001: SETUP params - src=1&fe=1&freq=12206.98&sr=27500&msys=dvbs2&mtype=8psk&pol=h&fec=34&ro=0.20&pids=0
2018-02-22 15:59:37.941 [  TRACE]:satip: 0001: PLAY params - addpids=1,16,17,8187
2018-02-22 15:59:38.315 [  TRACE]:satip: Status string: 'ver=1.0;src=1;tuner=1,0,1,0,12206,h,8psk,,0.20,dvbs2,27500,34;pids=0,1,16,17,8187'
2018-02-22 15:59:38.503 [  TRACE]:satip: Status string: 'ver=1.0;src=1;tuner=1,0,1,0,12206,h,8psk,,0.20,dvbs2,27500,34;pids=0,1,16,17,8187'
2018-02-22 15:59:38.793 [  TRACE]:satip: Status string: 'ver=1.0;src=1;tuner=1,0,1,0,12206,h,8psk,,0.20,dvbs2,27500,34;pids=0,1,16,17,8187'
2018-02-22 15:59:39.081 [  TRACE]:satip: Status string: 'ver=1.0;src=1;tuner=1,0,1,0,12206,h,8psk,,0.20,dvbs2,27500,34;pids=0,1,16,17,8187'
2018-02-22 15:59:39.365 [  TRACE]:satip: Status string: 'ver=1.0;src=1;tuner=1,0,1,0,12206,h,8psk,,0.20,dvbs2,27500,34;pids=0,1,16,17,8187'
2018-02-22 15:59:39.445 [  TRACE]:satip: 0001: PLAY params - addpids=79,257,258,259,265,291,297,307,308,309,311,312,313,315,317,318,319,320,321,322,323,324,325,326,327,332,333
2018-02-22 15:59:39.602 [  TRACE]:satip: Status string: 'ver=1.0;src=1;tuner=1,0,1,0,12206,h,8psk,,0.20,dvbs2,27500,34;pids=0,1,16,17,8187,79,257,258,259,265,291,297,307,308,309,311,312,313,315,317,318,319,320,321,322,323,324,325,326,327,332,333'
2018-02-22 15:59:39.979 [  TRACE]:satip: Status string: 'ver=1.0;src=1;tuner=1,0,1,0,12206,h,8psk,,0.20,dvbs2,27500,34;pids=0,1,16,17,8187,79,257,258,259,265,291,297,307,308,309,311,312,313,315,317,318,319,320,321,322,323,324,325,326,327,332,333'
2018-02-22 15:59:40.118 [  TRACE]:satip: 0001: PLAY params - delpids=333&addpids=18
2018-02-22 15:59:40.207 [  TRACE]:satip: Status string: 'ver=1.0;src=1;tuner=1,0,1,0,12206,h,8psk,,0.20,dvbs2,27500,34;pids=0,1,16,17,8187,79,257,258,259,265,291,297,307,308,309,311,312,313,315,317,318,319,320,321,322,323,324,325,326,327,332,18'
2018-02-22 15:59:40.415 [  TRACE]:satip: Status string: 'ver=1.0;src=1;tuner=1,0,1,0,12206,h,8psk,,0.20,dvbs2,27500,34;pids=0,1,16,17,8187,79,257,258,259,265,291,297,307,308,309,311,312,313,315,317,318,319,320,321,322,323,324,325,326,327,332,18'
2018-02-22 15:59:40.467 [  TRACE]:satip: 0001: PLAY params - delpids=79,257,258,259,265,291,297,307,308,309,311,312,313,315,317,318,319,320,321,322,323,324,325,326,327,332
2018-02-22 15:59:40.467 [  TRACE]:satip: 0001: PLAY params (split) - addpids=355,357,358,359,360,361,362,364,365,367,368,369,370,371,372,373,374,375,376,377,382,383
  ----- this is not accepted by the server
2018-02-22 15:59:40.624 [  TRACE]:satip: Status string: 'ver=1.0;src=1;tuner=1,0,1,0,12206,h,8psk,,0.20,dvbs2,27500,34;pids=0,1,16,17,8187,18'
2018-02-22 15:59:40.845 [  TRACE]:satip: Status string: 'ver=1.0;src=1;tuner=1,0,1,0,12206,h,8psk,,0.20,dvbs2,27500,34;pids=0,1,16,17,8187,18'
2018-02-22 15:59:41.067 [  TRACE]:satip: Status string: 'ver=1.0;src=1;tuner=1,0,1,0,12206,h,8psk,,0.20,dvbs2,27500,34;pids=0,1,16,17,8187,18'
2018-02-22 15:59:41.251 [  TRACE]:satip: Status string: 'ver=1.0;src=1;tuner=1,0,1,0,12206,h,8psk,,0.20,dvbs2,27500,34;pids=0,1,16,17,8187,18'
2018-02-22 15:59:41.474 [  TRACE]:satip: Status string: 'ver=1.0;src=1;tuner=1,0,1,0,12206,h,8psk,,0.20,dvbs2,27500,34;pids=0,1,16,17,8187,18'
2018-02-22 15:59:41.694 [  TRACE]:satip: Status string: 'ver=1.0;src=1;tuner=1,0,1,0,12206,h,8psk,,0.20,dvbs2,27500,34;pids=0,1,16,17,8187,18'
2018-02-22 15:59:41.905 [  TRACE]:satip: Status string: 'ver=1.0;src=1;tuner=1,225,1,15,12206,h,8psk,,0.20,dvbs2,27500,34;pids=0,1,16,17,8187,18'
2018-02-22 15:59:42.094 [  TRACE]:satip: Status string: 'ver=1.0;src=1;tuner=1,225,1,15,12206,h,8psk,,0.20,dvbs2,27500,34;pids=0,1,16,17,8187,18'
2018-02-22 15:59:42.315 [  TRACE]:satip: Status string: 'ver=1.0;src=1;tuner=1,225,1,15,12206,h,8psk,,0.20,dvbs2,27500,34;pids=0,1,16,17,8187,18'
2018-02-22 15:59:42.495 [  TRACE]:satip: Status string: 'ver=1.0;src=1;tuner=1,225,1,15,12206,h,8psk,,0.20,dvbs2,27500,34;pids=0,1,16,17,8187,18'
2018-02-22 15:59:42.716 [  TRACE]:satip: Status string: 'ver=1.0;src=1;tuner=1,225,1,15,12206,h,8psk,,0.20,dvbs2,27500,34;pids=0,1,16,17,8187,18'
2018-02-22 15:59:42.913 [  TRACE]:satip: Status string: 'ver=1.0;src=1;tuner=1,225,1,15,12206,h,8psk,,0.20,dvbs2,27500,34;pids=0,1,16,17,8187,18'
2018-02-22 15:59:43.134 [  TRACE]:satip: Status string: 'ver=1.0;src=1;tuner=1,225,1,15,12206,h,8psk,,0.20,dvbs2,27500,34;pids=0,1,16,17,8187,18'
2018-02-22 15:59:43.355 [  TRACE]:satip: Status string: 'ver=1.0;src=1;tuner=1,225,1,15,12206,h,8psk,,0.20,dvbs2,27500,34;pids=0,1,16,17,8187,18'
2018-02-22 15:59:43.539 [  TRACE]:satip: Status string: 'ver=1.0;src=1;tuner=1,225,1,15,12206,h,8psk,,0.20,dvbs2,27500,34;pids=0,1,16,17,8187,18'
2018-02-22 15:59:43.755 [  TRACE]:satip: Status string: 'ver=1.0;src=1;tuner=1,225,1,15,12206,h,8psk,,0.20,dvbs2,27500,34;pids=0,1,16,17,8187,18'
2018-02-22 15:59:43.975 [  TRACE]:satip: Status string: 'ver=1.0;src=1;tuner=1,225,1,15,12206,h,8psk,,0.20,dvbs2,27500,34;pids=0,1,16,17,8187,18'
2018-02-22 15:59:44.196 [  TRACE]:satip: Status string: 'ver=1.0;src=1;tuner=1,225,1,15,12206,h,8psk,,0.20,dvbs2,27500,34;pids=0,1,16,17,8187,18'
2018-02-22 15:59:44.380 [  TRACE]:satip: Status string: 'ver=1.0;src=1;tuner=1,225,1,15,12206,h,8psk,,0.20,dvbs2,27500,34;pids=0,1,16,17,8187,18'
2018-02-22 15:59:44.601 [  TRACE]:satip: Status string: 'ver=1.0;src=1;tuner=1,225,1,15,12206,h,8psk,,0.20,dvbs2,27500,34;pids=0,1,16,17,8187,18'
2018-02-22 15:59:44.786 [  TRACE]:satip: Status string: 'ver=1.0;src=1;tuner=1,225,1,15,12206,h,8psk,,0.20,dvbs2,27500,34;pids=0,1,16,17,8187,18'
2018-02-22 15:59:45.006 [  TRACE]:satip: Status string: 'ver=1.0;src=1;tuner=1,225,1,15,12206,h,8psk,,0.20,dvbs2,27500,34;pids=0,1,16,17,8187,18'
2018-02-22 15:59:45.227 [  TRACE]:satip: Status string: 'ver=1.0;src=1;tuner=1,225,1,15,12206,h,8psk,,0.20,dvbs2,27500,34;pids=0,1,16,17,8187,18'
2018-02-22 15:59:45.411 [  TRACE]:satip: Status string: 'ver=1.0;src=1;tuner=1,225,1,15,12206,h,8psk,,0.20,dvbs2,27500,34;pids=0,1,16,17,8187,18'
2018-02-22 15:59:45.632 [  TRACE]:satip: Status string: 'ver=1.0;src=1;tuner=1,225,1,15,12206,h,8psk,,0.20,dvbs2,27500,34;pids=0,1,16,17,8187,18'
2018-02-22 15:59:45.853 [  TRACE]:satip: Status string: 'ver=1.0;src=1;tuner=1,225,1,15,12206,h,8psk,,0.20,dvbs2,27500,34;pids=0,1,16,17,8187,18'
2018-02-22 15:59:46.074 [  TRACE]:satip: Status string: 'ver=1.0;src=1;tuner=1,225,1,15,12206,h,8psk,,0.20,dvbs2,27500,34;pids=0,1,16,17,8187,18'
2018-02-22 15:59:46.258 [  TRACE]:satip: Status string: 'ver=1.0;src=1;tuner=1,225,1,15,12206,h,8psk,,0.20,dvbs2,27500,34;pids=0,1,16,17,8187,18'
2018-02-22 15:59:46.479 [  TRACE]:satip: Status string: 'ver=1.0;src=1;tuner=1,225,1,15,12206,h,8psk,,0.20,dvbs2,27500,34;pids=0,1,16,17,8187,18'
2018-02-22 15:59:46.664 [  TRACE]:satip: Status string: 'ver=1.0;src=1;tuner=1,225,1,15,12206,h,8psk,,0.20,dvbs2,27500,34;pids=0,1,16,17,8187,18'
2018-02-22 15:59:46.884 [  TRACE]:satip: Status string: 'ver=1.0;src=1;tuner=1,225,1,15,12206,h,8psk,,0.20,dvbs2,27500,34;pids=0,1,16,17,8187,18'
2018-02-22 15:59:47.105 [  TRACE]:satip: Status string: 'ver=1.0;src=1;tuner=1,225,1,15,12206,h,8psk,,0.20,dvbs2,27500,34;pids=0,1,16,17,8187,18'
2018-02-22 15:59:47.289 [  TRACE]:satip: Status string: 'ver=1.0;src=1;tuner=1,225,1,15,12206,h,8psk,,0.20,dvbs2,27500,34;pids=0,1,16,17,8187,18'
2018-02-22 15:59:47.510 [  TRACE]:satip: Status string: 'ver=1.0;src=1;tuner=1,225,1,15,12206,h,8psk,,0.20,dvbs2,27500,34;pids=0,1,16,17,8187,18'
2018-02-22 15:59:47.732 [  TRACE]:satip: Status string: 'ver=1.0;src=1;tuner=1,225,1,15,12206,h,8psk,,0.20,dvbs2,27500,34;pids=0,1,16,17,8187,18'

You may add httpc to traces to see if tvh really sends the split addpids to the server. "--trace mpegts,satip,tbl-base,httpc"

#5 Updated by Ricardo Rocha 7 months ago

satipaxe!

#6 Updated by Ricardo Rocha 7 months ago

new log!

#7 Updated by Jaroslav Kysela 7 months ago

It's the server problem. I don't see this behaviour with latest build 15 - https://github.com/perexg/satip-axe/issues/94 . Also, reboot (of the server) might help.

#8 Updated by Ricardo Rocha 7 months ago

i used last satip-axe-201802211836-15 for the last traces and the behaviour was the same... however i am using minisatip7 and not minisatip8... i will change it reboot and make a new test.

will be updating this with the results in few minutes!

#9 Updated by Ricardo Rocha 7 months ago

  • File new_trace.log added

still the same problem with minisatip8 and reboot...

log attached! want me to paste the minisatip options here?

#10 Updated by Mark Clarkstone 7 months ago

  • File deleted (new_trace.log)

#11 Updated by Ricardo Rocha 7 months ago

note that i run minisatip with unicable

this is my options

MINISATIP8_OPTS="-u 0:0-1210,1:1-1420,2:2-1680,3:3-2040 -H 5:25 -b 4042752 -B 10000 -W 1"

and i tried

MINISATIP8_OPTS="-u 0:0-1210,1:1-1420,2:2-1680,3:3-2040"

MINISATIP8_OPTS="-u 0:1-1420,1:0-1210,2:2-1680,3:3-2040"

i even put back

STV6210_BAMP="16dB"

#12 Updated by Mark Clarkstone 7 months ago

#13 Updated by Jaroslav Kysela 7 months ago

This is really weird one. I cannot reproduce this. One RTSP command is just ignored somewhere. Could you add this code:

diff --git a/src/httpc.c b/src/httpc.c
index 65feef2c5..664c88a10 100644
--- a/src/httpc.c
+++ b/src/httpc.c
@@ -241,6 +241,7 @@ http_client_rbuf_cut( http_client_t *hc, size_t cut )
 static void
 http_client_cmd_destroy( http_client_t *hc, http_client_wcmd_t *cmd )
 {
+  tvhtrace(LS_HTTPC, "%04X: cmd destroy", shortid(hc));
   TAILQ_REMOVE(&hc->hc_wqueue, cmd, link);
   free(cmd->wbuf);
   free(cmd);
@@ -568,6 +569,10 @@ skip:
       }
       return http_client_flush(hc, -errno);
     }
+    if (tvhtrace_enabled()) {
+      tvhtrace(LS_HTTPC, "%04X: sent %s cmd", shortid(hc), http_ver2str(hc->hc_version));
+      tvhlog_hexdump(LS_HTTPC, wcmd->wbuf + wcmd->wpos, r);
+    }
     wcmd->wpos += r;
     if (wcmd->wpos >= wcmd->wsize) {
       res = HTTP_CON_SENT;
@@ -662,7 +667,7 @@ error:
   htsbuf_read(&q, body, body_size);

   if (tvhtrace_enabled()) {
-    tvhtrace(LS_HTTPC, "%04X: sending %s cmd", shortid(hc), http_ver2str(hc->hc_version));
+    tvhtrace(LS_HTTPC, "%04X: sending %s cmd (len %zd)", shortid(hc), http_ver2str(hc->hc_version), body_size);
     tvhlog_hexdump(LS_HTTPC, body, body_size);
   }

The code is attached - download the file and do 'cat <patchfile> | patch -p1' in the tvh git tree (directory with the Makefile file). Provide logs again.

#14 Updated by Ricardo Rocha 7 months ago

another update... even tried to revert back to version 14 on satipaxe and same result!

#15 Updated by Jaroslav Kysela 7 months ago

  • Status changed from New to Fixed
  • % Done changed from 0 to 100

#16 Updated by Jaroslav Kysela 7 months ago

I think that I found it, test latest - v4.3-1112-gd3b577a9e . The problem is in tvh not in the axe fw.

#17 Updated by Ricardo Rocha 7 months ago

i will never stop saying you do IMPRESSIVE THINGS....SOLVED.... one more time thanks!

#18 Updated by saen acro 7 months ago

after last update there is a error with compilation on Ubuntu 14.04

CC              src/lock.o
CC              src/string_list.o
src/httpc.c: In function ‘http_client_run0’:
src/httpc.c:1154:8: error: ‘res’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
     if (res < 0)
        ^
src/httpc.c:925:12: note: ‘res’ was declared here
   int ver, res, delimsize;
            ^
cc1: all warnings being treated as errors
make[2]: *** [/opt/build/tvheadend/build.linux/src/httpc.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory `/opt/build/tvheadend'
make[1]: *** [override_dh_auto_build] Error 2
make[1]: Leaving directory `/opt/build/tvheadend'
make: *** [build] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2

16.04 18.04 no problem

#19 Updated by saen acro 7 months ago

After d58fd123 compilation on 14.04 pass (/)

Also available in: Atom PDF