Project

General

Profile

Bug #4846

4.3 crashes when trying to add a recording

Added by Anders Gustafsson about 2 years ago. Updated about 2 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
Category:
Crashes
Target version:
-
Start date:
2018-01-13
Due date:
% Done:

100%

Estimated time:
Found in version:
4.3 (HTS Tvheadend 4.3-943~g9b85e7b7c)
Affected Versions:

Description

From the web interface. Also tried the Android TVH Client, but that one just said that it could not add a recording.

Steps to duplicate: In Web interface, select one entry in the EPG. Hit the small "Info" icon, then hit the "Record" button

2018-01-13 15:16:02.406 [ NOTICE] mpegts: mux 586MHz in Åland Network old params DVB-T freq 586000000 bw 8MHz cons QAM/64 hier AUTO code_rate 2/3:1/2 guard 1/8 trans 8k plp_id -1 (00000020)
2018-01-13 15:16:02.406 [ NOTICE] mpegts: mux 586MHz in Åland Network new params DVB-T freq 586000000 bw 8MHz cons QAM/64 hier AUTO code_rate 2/3:NONE guard 1/8 trans 8k plp_id -1 (00000020)
2018-01-13 15:16:06.059 [   INFO] subscription: 0006: "HTTP" unsubscribing from "SVT2 ABC", hostname="192.168.1.9", username="tvh", client="VLC/3.0.0-git LibVLC/3.0.0-git" 
2018-01-13 15:16:37.029 [  ALERT] CRASH: Signal: 11 in PRG: ./tvheadend (4.3-943~g9b85e7b7c) [2b293c8ca1c3e8058d18bf7405ddc52de3c0becc] CWD: /home/dalton/devel/tvh43/tvheadend/build.linux
2018-01-13 15:16:37.029 [  ALERT] CRASH: Fault address (nil) (Address not mapped)
2018-01-13 15:16:37.029 [  ALERT] CRASH: Loaded libraries: linux-vdso.so.1 /lib64/libssl.so.1.0.0 /lib64/libcrypto.so.1.0.0 /lib64/libz.so.1 /usr/lib64/liburiparser.so.1 /usr/lib64/libavahi-common.so.3 /usr/lib64/libavahi-client.so.3 /lib64/libdbus-1.so.3 /lib64/libdl.so.2 /lib64/libpthread.so.0 /lib64/libm.so.6 /lib64/librt.so.1 /usr/lib64/libstdc++.so.6 /lib64/libc.so.6 /lib64/ld-linux-x86-64.so.2 /lib64/libgcc_s.so.1
2018-01-13 15:16:37.029 [  ALERT] CRASH: Register dump [23]: 000000000000ffff000000000000000000007fd4b4d32cf000000000000000010000556b7b0bfb8b00007fd488095a9000007fd4880cf401000000000000000000000000000000000000556b7b0bfb8b000000000000000000007fd488095f9000000000000000000000000000000000000000000000000000007fd4729f350800007fd4b4c8f61a000000000001029300000000000000330000000000000004000000000000000efffffffe7ffbba130000000000000000
2018-01-13 15:16:37.029 [  ALERT] CRASH: STACKTRACE
2018-01-13 15:16:37.067 [  ALERT] CRASH: /home/dalton/devel/tvh43/tvheadend/src/trap.c:148 0x556b7a4b28aa 0x556b7a288000
2018-01-13 15:16:37.104 [  ALERT] CRASH: ??:0 0x7fd4b5852870 0x7fd4b5843000
2018-01-13 15:16:37.104 [  ALERT] CRASH: strlen+0x2a  (/lib64/libc.so.6)
2018-01-13 15:16:37.125 [  ALERT] CRASH: /home/dalton/devel/tvh43/tvheadend/src/htsmsg.c:355 0x556b7a4aa7c5 0x556b7a288000
2018-01-13 15:16:37.144 [  ALERT] CRASH: /home/dalton/devel/tvh43/tvheadend/src/api/api_dvr.c:230 0x556b7a4dd80a 0x556b7a288000
2018-01-13 15:16:37.163 [  ALERT] CRASH: /home/dalton/devel/tvh43/tvheadend/src/webui/webui_api.c:43 0x556b7a50b1f1 0x556b7a288000
2018-01-13 15:16:37.180 [  ALERT] CRASH: /home/dalton/devel/tvh43/tvheadend/src/http.c:1182 0x556b7a4816e3 0x556b7a288000
2018-01-13 15:16:37.195 [  ALERT] CRASH: /home/dalton/devel/tvh43/tvheadend/src/http.c:1319 0x556b7a482abc 0x556b7a288000
2018-01-13 15:16:37.211 [  ALERT] CRASH: /home/dalton/devel/tvh43/tvheadend/src/http.c:1468 0x556b7a481c33 0x556b7a288000
2018-01-13 15:16:37.225 [  ALERT] CRASH: /home/dalton/devel/tvh43/tvheadend/src/http.c:1955 0x556b7a482ebb 0x556b7a288000
2018-01-13 15:16:37.240 [  ALERT] CRASH: /home/dalton/devel/tvh43/tvheadend/src/http.c:2006 0x556b7a4830bc 0x556b7a288000
2018-01-13 15:16:37.254 [  ALERT] CRASH: /home/dalton/devel/tvh43/tvheadend/src/tcp.c:709 0x556b7a47a380 0x556b7a288000
2018-01-13 15:16:37.267 [  ALERT] CRASH: /home/dalton/devel/tvh43/tvheadend/src/wrappers.c:181 0x556b7a475ce2 0x556b7a288000

Associated revisions

Revision 33aac520 (diff)
Added by Jaroslav Kysela about 2 years ago

api: dvr - owner/representative might be NULL, fixes #4846

History

#1

Updated by Anders Gustafsson about 2 years ago

This is from Kodi, trying to add a recording:

15:25:39.715 T:4078359120  NOTICE: VideoPlayer: finished waiting
15:25:52.379 T:4078359120   ERROR: AddOnLog: Tvheadend HTSP Client: pvr.hts - Command addDvrEntry failed: Could not add dvrEntry
15:25:52.379 T:4078359120   ERROR: PVR - AddTimer - addon 'Tvheadend:192.168.1.110:9982' returned an error: server error
15:25:52.379 T:4078359120   ERROR: PVR - AddTimer - cannot add timer to client '2146250725': server error
#2

Updated by Christian Völkel about 2 years ago

Hi, my TVH 4.3 (HTS Tvheadend 4.3-943~g9b85e7b7c) doesn't crash and doesn't display any fault but I can't add a timer from Kodi... Over Webif no problems...

Kodi Log:

19:15:19.639 T:1944975824   ERROR: AddOnLog: Tvheadend HTSP Client: pvr.hts - Command addDvrEntry failed: Could not add dvrEntry
19:15:19.639 T:1944975824   ERROR: PVR - AddTimer - addon 'Tvheadend:192.168.160.1:9982' returned an error: server error
19:15:19.639 T:1944975824   ERROR: PVR - AddTimer - cannot add timer to client '2146250725': server error

#3

Updated by Mark Clarkstone about 2 years ago

I can confirm this.

The debug logs show..

2018-01-13 18:31:49.789 [  TRACE]:htsp-req: 192.168.1.151 [  | Kodi Media Center ] - request '{"eventId":1982639,"enabled":1,"startExtra":0,"stopExtra":0,"removal":92,"retention":2147483646,"priority":2,"seq":184,"method":"addDvrEntry"}'
2018-01-13 18:31:49.789 [  TRACE]:htsp-ans: 192.168.1.151 [  | Kodi Media Center ] - answer '{"error":"Could not add dvrEntry","success":0,"seq":184}'

#4

Updated by Mark Clarkstone about 2 years ago

  • Description updated (diff)
#5

Updated by Adam W about 2 years ago

Just noticed this too after updating to 4.3-943~g9b85e7b7c.

Recordings that were already scheduled are running fine, but if you go into the DVR tab on the WebGUI and try to press i for more information nothing happens.

Adding new recordings from the web GUI crashes TVHeadend totally.

#6

Updated by Markus S. about 2 years ago

i can confirm a crash and posted my relevant logs here : [[http://tvheadend.org/boards/5/topics/30821]]

#7

Updated by Jerome Jerome about 2 years ago

diff --git a/src/api/api_dvr.c b/src/api/api_dvr.c
index 336f315ad..cbc4d781c 100644
--- a/src/api/api_dvr.c
++ b/src/api/api_dvr.c
@ -227,7 +227,7 @ api_dvr_entry_create_by_event
conf = htsmsg_create_map();
htsmsg_copy_field(conf, "enabled", m, NULL);
htsmsg_copy_field(conf, "comment", m, NULL);
- htsmsg_add_str(conf, "owner", perm->aa_username);
htsmsg_add_str(conf, "owner", perm->aa_username ?: "");
htsmsg_add_str(conf, "creator", perm->aa_representative);
config_uuid = htsmsg_get_str(m, "config_uuid");
de = NULL;

#8

Updated by Anders Gustafsson about 2 years ago

Will this be pushed to git so that I can just do a git pull and rebuild?

#9

Updated by Jaroslav Kysela about 2 years ago

  • Status changed from New to Fixed
  • % Done changed from 0 to 100
#10

Updated by Anders Gustafsson about 2 years ago

Thanks. Will not build though?

[email protected]:~/devel/tvh43/tvheadend> git pull
remote: Counting objects: 44, done.
remote: Compressing objects: 100% (6/6), done.
remote: Total 44 (delta 38), reused 44 (delta 38), pack-reused 0
Unpacking objects: 100% (44/44), done.
From https://github.com/tvheadend/tvheadend
9b85e7b7c..33aac520c master > origin/master
Updating 9b85e7b7c..33aac520c
Fast-forward
src/api/api_dvr.c | 16 ++--

src/epggrab/otamux.c | 49 +++------------
src/htsmsg.c | 10 +++
src/htsmsg.h | 1 +
src/htsp_server.c | 28 +
++-----
src/idnode.c | 2
src/input/mpegts.h | 1 +
src/input/mpegts/dvb_psi.c | 29 +
+-------
src/input/mpegts/iptv/iptv.c | 13 +---
src/input/mpegts/iptv/iptv_udp.c | 9 +-
src/input/mpegts/linuxdvb/linuxdvb_frontend.c | 10 +
-
src/input/mpegts/mpegts_input.c | 36 +++--------
src/input/mpegts/mpegts_mux.c | 81 +
+++++++++----------------
src/input/mpegts/mpegts_mux_dvb.c | 5 +
src/input/mpegts/mpegts_network_scan.c | 12 +--
src/input/mpegts/mpegts_service.c | 11 +--

src/input/mpegts/mpegts_table.c | 4 +
src/input/mpegts/mpegts_tsdebug.c | 6 +

src/input/mpegts/satip/satip_frontend.c | 10 +
--
src/notify.c | 2
src/profile.c | 40 +
+++++------
src/subscriptions.c | 8 -
22 files changed, 150 insertions(
), 233 deletions()
[email protected]:~/devel/tvh43/tvheadend> make
make -f Makefile.webui LANGUAGES="ach ady ar bg cs da de en_US en_GB es et fa fi fr he hr hu it ko lv lt nl no pl pt ro ru sl sk sq sv tr uk zh zh-Hans" all
make1: Entering directory '/home/dalton/devel/tvh43/tvheadend'
make -f Makefile.webui WEBUI=std compile-std
make2: Entering directory '/home/dalton/devel/tvh43/tvheadend'
WEBUI std finished
make2: Leaving directory '/home/dalton/devel/tvh43/tvheadend'
make -f Makefile.webui WEBUI=debug compile-debug
make2: Entering directory '/home/dalton/devel/tvh43/tvheadend'
WEBUI debug finished
make2: Leaving directory '/home/dalton/devel/tvh43/tvheadend'
make1: Leaving directory '/home/dalton/devel/tvh43/tvheadend'
CC src/version.o
CC src/uuid.o
CC src/main.o
CC src/tvhlog.o
CC src/idnode.o
CC src/prop.o
CC src/proplib.o
CC src/utils.o
CC src/wrappers.o
CC src/tvhvfs.o
CC src/access.o
CC src/tcp.o
CC src/udp.o
CC src/url.o
CC src/http.o
CC src/notify.o
CC src/file.o
CC src/epg.o
CC src/epgdb.o
CC src/epggrab.o
CC src/spawn.o
CC src/packet.o
CC src/streaming.o
CC src/channels.o
CC src/subscriptions.o
CC src/service.o
CC src/htsp_server.o
CC src/htsmsg.o
src/htsmsg.c: In function ‘htsmsg_set_str2’:
src/htsmsg.c:467:1: error: control reaches end of non-void function [-Werror=return-type]
}
^
cc1: all warnings being treated as errors
Makefile:714: recipe for target '/home/dalton/devel/tvh43/tvheadend/build.linux/src/htsmsg.o' failed
make: *** [/home/dalton/devel/tvh43/tvheadend/build.linux/src/htsmsg.o] Error 1
[email protected]:~/devel/tvh43/tvheadend>

#11

Updated by Jaroslav Kysela about 2 years ago

It's fixed.

Also available in: Atom PDF