Project

General

Profile

Bug #4816

No more information in "Subtitle" available

Added by Alfred Zastrow 12 months ago. Updated 11 months ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
2018-01-08
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Found in version:
HTS Tvheadend 4.3-848~gc69368bae
Affected Versions:

Description

Hi,

see screenshot. Im using the EIT DVB grabber only without any change for a long time and this column used to be filed for the most channels.

br
Alfred

Bildschirmfoto vom 2017-12-26 06-23-41.png (153 KB) Bildschirmfoto vom 2017-12-26 06-23-41.png Alfred Zastrow, 2017-12-26 06:24
recordings_grid.jpg (43.7 KB) recordings_grid.jpg La Marqe, 2017-12-28 17:06
dvr.png (166 KB) dvr.png Mark Clarkstone, 2018-01-19 11:40

Subtasks

Bug #4837: DVr is not displaying/capturing Subtitle of show anymoreRejectedAdam Sutton

Associated revisions

Revision 47660042 (diff)
Added by Jaroslav Kysela 12 months ago

webui: show summary when subtitle field is empty, fixes #4816

Revision 10e3db37 (diff)
Added by Jaroslav Kysela 11 months ago

DVR: add code for the summary field, fixes #4816

History

#1 Updated by Jaroslav Kysela 12 months ago

  • Status changed from New to Fixed
  • % Done changed from 0 to 100

#2 Updated by La Marqe 12 months ago

I would like to reopen this bug.

The above change fixes only the WebUI, but not the file name pattern %s for recordings.

#3 Updated by La Marqe 12 months ago

Not just the recording file names are incomplete, also the WebUI is fixed only partially.

The subtitle columns in the recording grids are empty.

#4 Updated by Jaroslav Kysela 12 months ago

  • Subject changed from No more information in "Subtitle" availble to No more information in "Subtitle" available
  • Status changed from Fixed to Accepted

There is no subtitle in EIT data. Previous version of tvh just make a copy of the summary text to the subtitle, but it's not correct.

#5 Updated by La Marqe 12 months ago

I see your point.

Adding a new column and new % pattern for the summary text would be an equally good solution to me and would avoid further extension of the previous hack.

#6 Updated by Robin Mitra 11 months ago

Jaroslav Kysela wrote:

There is no subtitle in EIT data. Previous version of tvh just make a copy of the summary text to the subtitle, but it's not correct.

The epg shows subtitle, so the eit has it (and I confirmed that with other tools), and that was also used in the dvr settings, but not anymore.
I can understand that some providers don't set it, but most do. Shouldn't that take precedence over any other info gleaned from guessing at description fields?

#7 Updated by Jaroslav Kysela 11 months ago

EPG grid shows summary when subtitle is empty (see the new header description). Something similar should be added for DVR, but I'm working on other things at the moment.

#8 Updated by Robin Mitra 11 months ago

I get what you're trying to do.
Only I fear that an advanced (as in nice to have) feature is currently breaking a working basic feature.

Shouldn't a newly commited feature attempt be rejected if it breaks an existing and working basic feature?

#9 Updated by Michael Schönborn 11 months ago

I don't know if this issue was already fixed, but after I recreated all autorecs out of the EPG all subtitles were also shown in the upcoming recordings tab. Even the duplicates from the finished recordings where filtered.

I will wait, if the next recordings will be successful and the subtitle will be added to the filename. And if the future recordings after a epg update will also show the subtitle.

#10 Updated by Daniel Mayer 11 months ago

+1 to buggy-in-usage.
The working not-correct feature should not removed before "correct" feature runs.
It's fact that now there's no recording of series possible as the files are only counted "Stargate SG1 - 1.ts" -2, -3, etc. Until December the subtitles where in the filename.

1) You could provide an option field for old/new habit in Recording-profile
2) I understand the changeset above as: "summary" should not fill in for "subtitle". So: Add the action to save "summary" to disk instead als .eit-file with same filename to your changeset.

#11 Updated by Daniel Mayer 11 months ago

Edit: possibly faulty "summary" should not fill in for "subtitle" is what I understood out of your changeset.

#12 Updated by Jaroslav Kysela 11 months ago

It's definitely bug to "propagate" directly and blindly a copy of summary to subtitle field from the EPG grabber to the upper layers. The commit which removed this (by default) is https://github.com/tvheadend/tvheadend/commit/9b40e5a26915161e6904001154afdb3e68de49d0 , so as you can see, it's possible to revert to the old behaviour in the EIT config by checking one checkbox.

I'm working on a proper solution (will be released probably tomorrow, because other code cleanups).

#13 Updated by Jaroslav Kysela 11 months ago

  • Status changed from Accepted to Fixed

#14 Updated by Robin Mitra 11 months ago

Jaroslav Kysela wrote:

...
revert to the old behaviour in the EIT config by checking one checkbox.

I need to find that config, didn't know that existed (or forgot about it)

#15 Updated by Robin Mitra 11 months ago

This is still broken.

The fact that it got rejected tells me that the subtitle feature is gone in favor of something that noone understands and can use except maybe the author.
This renders the dvr pretty much useless for series recordings for normal mortals.

#16 Updated by Mark Clarkstone 11 months ago

From my small testing there does seem to be some issues with the subtitle processing, but imo, it's nothing major.

What I observed.

If you have more than one grabber enabled & scraping the subtitle from the description is enabled for all, it will sometimes be correctly processed and added to the DVR subtitle, but not always. This is usually due to the winning grabber not having that info, so, no problem there..


Before I started to tinker, I'd not set the "Set subtitle to summary" option for any of the grabbers, I did have the scrap subtitle option enabled (for all).

My DVR list of upcoming recordings had the correct subtitle for "Doctors" on BBC One. Once I had enabled "Set subtitle to summary" (for all) and re-enabled the autorec of "Doctors" the subtitle disappeared for all but one entry.

This is with 4.3-985, I see there's 4.3.991 out so I'll update and see if that makes a difference.

Also available in: Atom PDF