Project

General

Profile

Bug #2539

cppcheck 1.67 findings in v3.9-2208-g5ba389b

Added by Johan Rehnberg over 7 years ago. Updated over 7 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
Category:
General
Target version:
-
Start date:
2014-12-06
Due date:
% Done:

0%

Estimated time:
Found in version:
v3.9-2208-g5ba389b
Affected Versions:

Description

The errors in htsp_server.c and http.c look rather serious.

$ cppcheck -q src/
[src/htsmsg.c:911]: (error) Common realloc mistake: 'ret' nulled but not freed upon failure
[src/htsmsg.c:914]: (error) Common realloc mistake: 'ret' nulled but not freed upon failure
[src/htsmsg.c:917]: (error) Common realloc mistake: 'ret' nulled but not freed upon failure
[src/htsp_server.c:2503]: (error) Address of local auto-variable assigned to a function parameter.
[src/http.c:986]: (error) Address of local auto-variable assigned to a function parameter.
[src/idnode.c:617]: (error) Uninitialized variable: skel
[src/idnode.c:619]: (error) Uninitialized variable: skel
[src/input/mpegts/mpegts_input.c:831]: (error) Memory is allocated but not initialized: mtf
[src/misc/dbl.c:272]: (error) Uninitialized variable: flag_rtz
[src/parsers/parser_avc.c:151]: (error) Common realloc mistake: 'sps_array' nulled but not freed upon failure
[src/parsers/parser_avc.c:152]: (error) Common realloc mistake: 'sps_size_array' nulled but not freed upon failure
[src/parsers/parser_avc.c:157]: (error) Common realloc mistake: 'pps_size_array' nulled but not freed upon failure
[src/parsers/parser_avc.c:158]: (error) Common realloc mistake: 'pps_array' nulled but not freed upon failure
[src/spawn.c:379]: (error) Memory leak: a
[src/tvhpoll.c:87]: (error) Uninitialized variable: fd
[src/webui/webui.c:391]: (error) Memory leak: hostpath
[src/webui/webui.c:427]: (error) Memory leak: hostpath
[src/webui/webui.c:465]: (error) Memory leak: hostpath
[src/webui/webui.c:516]: (error) Memory leak: hostpath
[src/webui/webui.c:627]: (error) Memory leak: hostpath
[src/webui/webui.c:997]: (error) Memory leak: hostpath
[src/webui/webui.c:1029]: (error) Memory leak: hostpath

History

#1

Updated by Jaroslav Kysela over 7 years ago

  • Status changed from New to Fixed

I reviewed all lines and except the memory leaks are all false-positive. The memory leaks should be fixed in master now. Thanks.

Also available in: Atom PDF