Project

General

Profile

Bug #2070

Missing validation on tag name (can be empty)

Added by Sam Stenvall over 5 years ago. Updated over 5 years ago.

Status:
Accepted
Priority:
Normal
Assignee:
-
Category:
Configuration
Target version:
-
Start date:
2014-04-21
Due date:
% Done:

0%

Estimated time:
Found in version:
master
Affected Versions:

Description

Some guy on the XBMC forum has managed to create an empty tag (see http://xbmclogs.com/show.php?id=182355). This should not be possible since a tag with no name makes no sense.

It could be ignored in the pvr.tvh addon but that seems like an unnecessary hack (XBMC ignores it anyway).

History

#1

Updated by Adam Sutton over 5 years ago

Most likely the user manually hacked the configuration files or possibly something went wrong during config migration?

But yeah a simple validation on load would probably not be a bad idea. The only thing I'd say is you start here and you'll end up with needing validation all over the shop! TVH generally takes a pretty light approach to configuration validation, there are various reasons for this (mainly because we're lazy), but also because its intended to be used by people that have a vague idea of what they're doing but checks usually exist at point of entry rather than when loading the config.

#2

Updated by Adam Sutton over 5 years ago

  • Status changed from New to Accepted

Also available in: Atom PDF