bundle - strtok() race in fb_opendir()
I experience a re-entrant race in fb_opendir() function. See patch for details.
Fix #1454 - Remove usage of non re-entrant strtok()
Thanks to Jaroslav Kysela <[email protected]> for providing the initial fix.
(cherry picked from commit 86fac417c20734383e904e38169f1c88b42a6da9)
(cherry picked from commit 7d97d1f648ed720785eac367481d8e56ea8f1ff8)
(cherry picked from commit a420c83a0e0d2c31c2c15d0fec6fedc3f5a36dfe)
Updated by Adam Sutton about 8 years ago
- Status changed from New to Accepted
- Assignee set to Adam Sutton
- Affected Versions 3.2, 3.3 added
Agreed, but I think the problem is more general than this.
I think we should probably avoid using strtok() anywhere that requires a second call, else we need to carefully check all such instances to ensure they are only called from a single thread.